fix: Add NoneType as a local member to the _common module#50
Open
hutcheb wants to merge 1 commit intoethanfurman:masterfrom
Open
fix: Add NoneType as a local member to the _common module#50hutcheb wants to merge 1 commit intoethanfurman:masterfrom
hutcheb wants to merge 1 commit intoethanfurman:masterfrom
Conversation
Author
|
There are then some other issue with the tests when using pypy, but they don't seem to be related to this. It looks like it might be related to the ordering of the R,W,X attributes in the Perm test Flag class. Looks like pypy orders them differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32 Provides a consistent way to handle the NoneType. Now even when using pypy it creates a local attribute in the _common module, this is imported in the init.py, where if we don't have attribute but it is declared in the slots then it freaks out.
try:
NoneType
except NameError:
NoneType = type(None)
try:
NoneType = NoneType
except NameError:
NoneType = type(None)